Issue 82793004: Add field and function view for libraries. Rough cut.

Issue 82793004: Add field and function view for libraries. Rough cut. (Closed)

Created:
7 years ago by turnidge

Modified:
7 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add field and function view for libraries. Rough cut. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30596

Patch Set 6 : #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -42 lines)			Patch
M	runtime/bin/vmservice/client/deployed/web/index.html	View	1 2 3	2 chunks	+55 lines, -7 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/observatory_elements/library_view.html	View		1 chunk	+49 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View		22 chunks	+76 lines, -27 lines	0 comments	Download
M	runtime/vm/object_id_ring.cc	View	1	1 chunk	+1 line, -1 line	1 comment	Download
M	tests/standalone/vmservice/isolate_class_test.dart	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

turnidge

I wanted to get these changes in for Ivan to play with before I leave ...

7 years ago (2013-11-22 22:27:41 UTC) #1

Ivan Posva

LGTM -ip https://codereview.chromium.org/82793004/diff/1/runtime/bin/vmservice/client/lib/src/observatory/application.dart File runtime/bin/vmservice/client/lib/src/observatory/application.dart (right): https://codereview.chromium.org/82793004/diff/1/runtime/bin/vmservice/client/lib/src/observatory/application.dart#newcode30 runtime/bin/vmservice/client/lib/src/observatory/application.dart:30: ? https://codereview.chromium.org/82793004/diff/1/runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.dart File runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.dart (right): https://codereview.chromium.org/82793004/diff/1/runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.dart#newcode14 runtime/bin/vmservice/client/lib/src/observatory_elements/error_view.dart:14: ...

7 years ago (2013-11-22 22:38:12 UTC) #2

turnidge

Also added some changes for the failing test -- it was sensitive to the suppression ...

7 years ago (2013-11-22 22:49:58 UTC) #3

Ivan Posva

https://codereview.chromium.org/82793004/diff/190008/runtime/vm/object_id_ring.cc File runtime/vm/object_id_ring.cc (right): https://codereview.chromium.org/82793004/diff/190008/runtime/vm/object_id_ring.cc#newcode89 runtime/vm/object_id_ring.cc:89: // TODO(turnidge): Do not enter Smis into the ObjectIdRing. ...

7 years ago (2013-11-22 22:58:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #6 manually as r30596 (presubmit successful).

Expand Messages | Collapse Messages