Issue 82293002: - Update use of kPageSize in ifdef'd MIPS code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 82293002: - Update use of kPageSize in ifdef'd MIPS code. (Closed)

Created:
7 years, 1 month ago by Ivan Posva

Modified:
7 years, 1 month ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Update use of kPageSize in ifdef'd MIPS code. Committed: https://code.google.com/p/dart/source/detail?r=30558

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	runtime/vm/find_code_object_test.cc	View		1 chunk	+2 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Committed patchset #1 manually as r30558 (presubmit successful).

7 years, 1 month ago (2013-11-22 00:41:15 UTC) #1

Ivan Posva

TBR https://codereview.chromium.org/82293002/diff/1/runtime/vm/find_code_object_test.cc File runtime/vm/find_code_object_test.cc (right): https://codereview.chromium.org/82293002/diff/1/runtime/vm/find_code_object_test.cc#newcode145 runtime/vm/find_code_object_test.cc:145: #if defined(TARGET_ARCH_MIPS) @zra: Is this ifdef still needed? ...

7 years, 1 month ago (2013-11-22 00:42:09 UTC) #2

zra

7 years, 1 month ago (2013-11-22 21:36:32 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/82293002/diff/1/runtime/vm/find_code_object_t...
File runtime/vm/find_code_object_test.cc (right):

https://codereview.chromium.org/82293002/diff/1/runtime/vm/find_code_object_t...
runtime/vm/find_code_object_test.cc:145: #if defined(TARGET_ARCH_MIPS)
On 2013/11/22 00:42:09, Ivan Posva wrote:
> @zra: Is this ifdef still needed? The comment seems a bit outdated.

It isn't needed. Removing in https://codereview.chromium.org/84073003/

Expand Messages | Collapse Messages