Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: runtime/vm/find_code_object_test.cc

Issue 82293002: - Update use of kPageSize in ifdef'd MIPS code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/find_code_object_test.cc
===================================================================
--- runtime/vm/find_code_object_test.cc (revision 30557)
+++ runtime/vm/find_code_object_test.cc (working copy)
@@ -144,9 +144,9 @@
pc = code.EntryPoint() + 16;
#if defined(TARGET_ARCH_MIPS)
Ivan Posva 2013/11/22 00:42:09 @zra: Is this ifdef still needed? The comment seem
zra 2013/11/22 21:36:33 It isn't needed. Removing in https://codereview.ch
// MIPS can only Branch +/- 128KB
- EXPECT(code.Size() > (PageSpace::kPageSize / 2));
+ EXPECT(code.Size() > ((PageSpace::kPageSizeInWords << kWordSizeLog2) / 2));
EXPECT(Code::LookupCode(pc) == code.raw());
- pc = code.EntryPoint() + (PageSpace::kPageSize / 4);
+ pc = code.EntryPoint() + ((PageSpace::kPageSizeInWords << kWordSizeLog2) / 4);
EXPECT(Code::LookupCode(pc) == code.raw());
#else
EXPECT(code.Size() > (PageSpace::kPageSizeInWords << kWordSizeLog2));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698