Issue 819143007: Incorporate some code review comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 819143007: Incorporate some code review comments. (Closed)

Created:
5 years, 11 months ago by Kevin Millikin (Google)

Modified:
5 years, 11 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Incorporate some code review comments. Change the CPS IR's LetCont constructor to have single and multiple continuation versions. Update a pair of comments. R=asgerf@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43071

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -31 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View	16 chunks	+33 lines, -27 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Kevin Millikin (Google)

5 years, 11 months ago (2015-01-22 13:09:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 43071 (presubmit successful).