Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart

Issue 819143007: Incorporate some code review comments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // SExpressionUnstringifier implements the inverse operation to 5 // SExpressionUnstringifier implements the inverse operation to
6 // [SExpressionStringifier]. 6 // [SExpressionStringifier].
7 7
8 library sexpr_unstringifier; 8 library sexpr_unstringifier;
9 9
10 import 'package:compiler/src/constants/expressions.dart' 10 import 'package:compiler/src/constants/expressions.dart'
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 List<Continuation> continuations = <Continuation>[]; 490 List<Continuation> continuations = <Continuation>[];
491 while (tokens.current != ")") { 491 while (tokens.current != ")") {
492 continuations.add(parseContinuation()); 492 continuations.add(parseContinuation());
493 } 493 }
494 tokens.consumeEnd(); 494 tokens.consumeEnd();
495 495
496 // body) 496 // body)
497 Expression body = parseExpression(); 497 Expression body = parseExpression();
498 tokens.consumeEnd(); 498 tokens.consumeEnd();
499 499
500 return new LetCont(continuations, body); 500 return new LetCont.many(continuations, body);
501 } 501 }
502 502
503 /// (SetClosureVariable name value body) 503 /// (SetClosureVariable name value body)
504 SetClosureVariable parseSetClosureVariable() { 504 SetClosureVariable parseSetClosureVariable() {
505 tokens.consumeStart(SET_CLOSURE_VARIABLE); 505 tokens.consumeStart(SET_CLOSURE_VARIABLE);
506 506
507 ClosureVariable local = name2variable[tokens.read()]; 507 ClosureVariable local = name2variable[tokens.read()];
508 Primitive value = name2variable[tokens.read()]; 508 Primitive value = name2variable[tokens.read()];
509 assert(value != null); 509 assert(value != null);
510 510
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
690 return new ReifyTypeVar(type); 690 return new ReifyTypeVar(type);
691 } 691 }
692 692
693 /// (This) 693 /// (This)
694 This parseThis() { 694 This parseThis() {
695 tokens.consumeStart(THIS); 695 tokens.consumeStart(THIS);
696 tokens.consumeEnd(); 696 tokens.consumeEnd();
697 return new This(); 697 return new This();
698 } 698 }
699 } 699 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698