Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 816703003: Report the correct number of tests when tests are skipped due to compile time errors. (Closed)

Created:
6 years ago by ricow1
Modified:
6 years ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Report the correct number of tests when tests are skipped due to compile time errors. The current setup will count tests that are skipped when runtime is a browser due to compile time errors twice. Example: tools/test.py -mrelease -rdrt -cdart2js --report language/bad_override <snip> Total: 10 tests * 0 tests will be skipped (0 skipped by design) * 0 tests are expected to be flaky but not crash * 5 tests are expected to pass * 0 tests are expected to fail that we won't fix * 2 tests are expected to fail that we should fix * 0 tests are expected to crash that we should fix * 0 tests are allowed to timeout * 3 tests are skipped on browsers due to compile-time error This is a multitest that has 7 tests (including none). 3 of these are giving compile-time errors, 2 of these are failing (as a compile-time error when they should not, but that is not the point), 2 are passing. This is preparation of a bigger refactoring of the summary reporting, so that I can have sane numbers for validation. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=42460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/testing/dart/test_suite.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years ago (2014-12-18 15:04:36 UTC) #1
kustermann
lgtm [The testoutcome.log files we write give the most accurate information about test runs. The ...
6 years ago (2014-12-18 15:09:44 UTC) #2
ricow1
On 2014/12/18 15:09:44, kustermann wrote: > lgtm > > [The testoutcome.log files we write give ...
6 years ago (2014-12-18 15:14:23 UTC) #3
ricow1
6 years ago (2014-12-18 15:15:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r42460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698