Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 816703003: Report the correct number of tests when tests are skipped due to compile time errors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 return; 269 return;
270 } 270 }
271 // Test if the selector includes this test. 271 // Test if the selector includes this test.
272 RegExp pattern = configuration['selectors'][suiteName]; 272 RegExp pattern = configuration['selectors'][suiteName];
273 if (!pattern.hasMatch(testCase.displayName)) { 273 if (!pattern.hasMatch(testCase.displayName)) {
274 return; 274 return;
275 } 275 }
276 276
277 // Update Summary report 277 // Update Summary report
278 if (configuration['report']) { 278 if (configuration['report']) {
279 SummaryReport.add(expectations);
280 if (testCase.expectCompileError && 279 if (testCase.expectCompileError &&
281 TestUtils.isBrowserRuntime(configuration['runtime']) && 280 TestUtils.isBrowserRuntime(configuration['runtime']) &&
282 new CompilerConfiguration(configuration).hasCompiler) { 281 new CompilerConfiguration(configuration).hasCompiler) {
283 SummaryReport.addCompileErrorSkipTest(); 282 SummaryReport.addCompileErrorSkipTest();
284 return; 283 return;
284 } else {
285 SummaryReport.add(expectations);
285 } 286 }
286 } 287 }
287 288
288 // Handle skipped tests 289 // Handle skipped tests
289 if (expectations.contains(Expectation.SKIP) || 290 if (expectations.contains(Expectation.SKIP) ||
290 expectations.contains(Expectation.SKIP_BY_DESIGN)) { 291 expectations.contains(Expectation.SKIP_BY_DESIGN)) {
291 return; 292 return;
292 } 293 }
293 294
294 doTest(testCase); 295 doTest(testCase);
(...skipping 2175 matching lines...) Expand 10 before | Expand all | Expand 10 after
2470 * $pass tests are expected to pass 2471 * $pass tests are expected to pass
2471 * $failOk tests are expected to fail that we won't fix 2472 * $failOk tests are expected to fail that we won't fix
2472 * $fail tests are expected to fail that we should fix 2473 * $fail tests are expected to fail that we should fix
2473 * $crash tests are expected to crash that we should fix 2474 * $crash tests are expected to crash that we should fix
2474 * $timeout tests are allowed to timeout 2475 * $timeout tests are allowed to timeout
2475 * $compileErrorSkip tests are skipped on browsers due to compile-time error 2476 * $compileErrorSkip tests are skipped on browsers due to compile-time error
2476 """; 2477 """;
2477 print(report); 2478 print(report);
2478 } 2479 }
2479 } 2480 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698