Issue 816103002: Add InstrumentationService.logPriorityException() and use logException() in refactorings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 816103002: Add InstrumentationService.logPriorityException() and use logException() in refactorings. (Closed)

Created:
6 years ago by scheglov

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Add InstrumentationService.logPriorityException() and use logException() in refactorings. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42530

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -5 lines)			Patch
M	pkg/analysis_server/lib/driver.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/instrumentation/instrumentation.dart	View	2 chunks	+16 lines, -3 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/816103002/diff/1/pkg/analyzer/lib/instrumentation/instrumentation.dart File pkg/analyzer/lib/instrumentation/instrumentation.dart (right): https://codereview.chromium.org/816103002/diff/1/pkg/analyzer/lib/instrumentation/instrumentation.dart#newcode75 pkg/analyzer/lib/instrumentation/instrumentation.dart:75: void logException(dynamic exception, StackTrace stackTrace) { We might ...

6 years ago (2014-12-19 22:36:18 UTC) #2

scheglov

6 years ago (2014-12-19 23:00:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42530 (presubmit successful).

Expand Messages | Collapse Messages