Add InstrumentationService.logPriorityException() and use logException() in refactorings.

pkg/analyzer/lib/instrumentation/instrumentation.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library instrumentation;
 
 /**
  * The interface used by client code to communicate with an instrumentation
  * server.
  */
@@ skipping 51 matching lines @@
    * given [instrumentationServer].
    */
   InstrumentationService(this._instrumentationServer);
 
   /**
    * The current time, expressed as a decimal encoded number of milliseconds.
    */
   String get _timestamp => new DateTime.now().millisecondsSinceEpoch.toString();
 
   /**
-   * Log that the given [exception] was thrown, with the given [stackTrace].
+   * Log that the given non-priority [exception] was thrown, with the given
+   * [stackTrace].
    */
   void logException(dynamic exception, StackTrace stackTrace) {

[Brian Wilkerson, 2014/12/19 22:36:18]

We might want to add another parameter that can contain some additional text.
For example, in this case it might be useful to also log the request that caused
the exception. We can always decide whether to do this later if you want.

     if (_instrumentationServer != null) {
       String message = _toString(exception);
       String trace = _toString(stackTrace);
-      _instrumentationServer.logWithPriority(
-          '$_timestamp:$TAG_EXCEPTION:$message:$trace');
+      _instrumentationServer.log('$_timestamp:$TAG_EXCEPTION:$message:$trace');
     }
   }
 
   /**
    * Log that a notification has been sent to the client.
    */
   void logNotification(String notification) {
     _log(TAG_NOTIFICATION, notification);
   }
 
   /**
+   * Log that the given priority [exception] was thrown, with the given
+   * [stackTrace].
+   */
+  void logPriorityException(dynamic exception, StackTrace stackTrace) {
+    if (_instrumentationServer != null) {
+      String message = _toString(exception);
+      String trace = _toString(stackTrace);
+      _instrumentationServer.logWithPriority(
+          '$_timestamp:$TAG_EXCEPTION:$message:$trace');
+    }
+  }
+
+  /**
    * Log that a request has been sent to the client.
    */
   void logRequest(String request) {
     _log(TAG_REQUEST, request);
   }
 
   /**
    * Log that a response has been sent to the client.
    */
   void logResponse(String response) {
@@ skipping 24 matching lines @@
   /**
    * Convert the given [object] to a string.
    */
   String _toString(Object object) {
     if (object == null) {
       return 'null';
     }
     return object.toString();
   }
 }