Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 815173002: Add code comments to inline cache stubs. (Closed)

Created:
6 years ago by srdjan
Modified:
6 years ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add code comments to inline cache stubs. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=42520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -13 lines) Patch
M runtime/vm/stub_code_arm.cc View 7 chunks +8 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 8 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 8 chunks +10 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 7 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 7 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
srdjan
6 years ago (2014-12-19 17:00:32 UTC) #2
hausner
lgtm
6 years ago (2014-12-19 17:11:26 UTC) #3
srdjan
6 years ago (2014-12-19 18:40:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r42520 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698