Issue 813753002: Change the S-expression representation of constant values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 813753002: Change the S-expression representation of constant values. (Closed)

Created:
6 years ago by Kevin Millikin (Google)

Modified:
6 years ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Change the S-expression representation of constant values. Before we called toStructuredString, which made no guarantee to produce something that could be parsed as an S-expression. Instead implement our own conversion to S-expressions. R=karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42438

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+432 lines, -376 lines)			Patch
M	pkg/analyzer2dart/test/sexpr_data.dart	View	73 chunks	+155 lines, -155 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart	View	3 chunks	+68 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/backend_dart/opt_constprop_test.dart	View	12 chunks	+88 lines, -88 lines	0 comments	Download
M	tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart	View	7 chunks	+35 lines, -35 lines	0 comments	Download
M	tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart	View	10 chunks	+26 lines, -26 lines	0 comments	Download
M	tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart	View	2 chunks	+60 lines, -71 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

6 years ago (2014-12-17 15:19:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42438 (presubmit successful).

Expand Messages | Collapse Messages