Change the S-expression representation of constant values.

tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // SExpressionUnstringifier implements the inverse operation to
 // [SExpressionStringifier].
 
 library sexpr_unstringifier;
 
 import 'package:compiler/src/constants/expressions.dart'
@@ skipping 124 matching lines @@
   static const String GET_CLOSURE_VARIABLE = "GetClosureVariable";
   static const String LITERAL_LIST = "LiteralList";
   static const String LITERAL_MAP = "LiteralMap";
   static const String REIFY_TYPE_VAR = "ReifyTypeVar";
   static const String THIS = "This";
 
   // Other
   static const String FUNCTION_DEFINITION = "FunctionDefinition";
   static const String IS_TRUE = "IsTrue";
 
+  // Constants
+  static const String BOOL = "Bool";
+  static const String DOUBLE = "Double";
+  static const String INT = "Int";
+  static const String NULL = "Null";
+  static const String STRING = "String";
+
   final Map<String, Definition> name2variable =
       <String, Definition>{ "return": new Continuation.retrn() };
 
   // Operator names used for canonicalization. In theory, we could simply use
   // Elements.isOperatorName() on the parsed tokens; however, comparisons are
   // done using identical() for performance reasons, which are reliable only for
   // compile-time literal strings.
   static Set<String> OPERATORS = new Set<String>.from(
       [ '~', '==', '[]', '*', '/', '%', '~/', '+', '<<', 'unary-'
       , '>>', '>=', '>', '<=', '<', '&', '^', '|', '[]=', '-'
@@ skipping 414 matching lines @@
       default:
         assert(false);
     }
 
     return null;
   }
 
   /// (Constant (constant))
   Constant parseConstant() {
     tokens.consumeStart(CONSTANT);
+    tokens.consumeStart();
+    Constant result;
     String tag = tokens.read();
-
-    // NullConstant.
-    if (tag == "NullConstant") {
-      tokens.consumeEnd();
-      return new Constant(
-          new PrimitiveConstantExpression(new NullConstantValue()));
+    switch (tag) {
+      case NULL:
+        result = new Constant(
+            new PrimitiveConstantExpression(new NullConstantValue()));
+        break;
+      case BOOL:
+        String value = tokens.read();
+        if (value == "true") {
+          result = new Constant(
+              new PrimitiveConstantExpression(new TrueConstantValue()));
+        } else if (value == "false") {
+          result = new Constant(
+              new PrimitiveConstantExpression(new FalseConstantValue()));
+        } else {
+          throw "Invalid Boolean value '$value'.";
+        }
+        break;
+      case STRING:
+        List<String> strings = <String>[];
+        do {
+          strings.add(tokens.read());
+        } while (tokens.current != ")");
+        String string = strings.join(" ");
+        assert(string.startsWith('"') && string.endsWith('"'));
+        StringConstantValue value = new StringConstantValue(
+            new LiteralDartString(string.substring(1, string.length - 1)));
+        result = new Constant(new PrimitiveConstantExpression(value));
+        break;
+      case INT:
+        String value = tokens.read();
+        int intValue = int.parse(value, onError: (_) => null);
+        if (intValue == null) {
+          throw "Invalid int value 'value'.";
+        }
+        result = new Constant(
+            new PrimitiveConstantExpression(new IntConstantValue(intValue)));
+        break;
+      case DOUBLE:
+        String value = tokens.read();
+        double doubleValue = double.parse(value, (_) => null);
+        if (doubleValue == null) {
+          throw "Invalid double value '$value'.";
+        }
+        result = new Constant(new PrimitiveConstantExpression(
+            new DoubleConstantValue(doubleValue)));
+        break;
+      default:
+        throw "Unexpected constant tag '$tag'.";
     }
-
-    // BoolConstant.
-    if (tag == "BoolConstant") {
-      tokens.consumeStart();
-      tag = tokens.read();
-      tokens.consumeEnd();
-      tokens.consumeEnd();
-      if (tag == "true") {
-        return new Constant(new PrimitiveConstantExpression(
-            new TrueConstantValue()));
-      } else if (tag == "false") {
-        return new Constant(new PrimitiveConstantExpression(
-            new FalseConstantValue()));
-      }
-      throw "Invalid bool value '$tag'.";
-    }
-
-    // StringConstant.
-    if (tag == "StringConstant") {
-      tokens.consumeStart();
-      List<String> strings = <String>[];
-      do {
-        strings.add(tokens.read());
-      } while (tokens.current != ")");
-      tokens.consumeEnd();
-
-      String string = strings.join(" ");
-      assert(string.startsWith('"') && string.endsWith('"'));
-
-      StringConstantValue value = new StringConstantValue(
-          new LiteralDartString(string.substring(1, string.length - 1)));
-
-      tokens.consumeEnd();
-      return new Constant(new PrimitiveConstantExpression(value));
-    }
-
-    // IntConstant.
-    if (tag == "IntConstant") {
-      tokens.consumeStart();
-      tag = tokens.read();
-      int intValue = int.parse(tag, onError: (_) => null);
-      if (intValue == null) {
-        throw "Invalid int value '$tag'.";
-      }
-      tokens.consumeEnd();
-      tokens.consumeEnd();
-      return new Constant(new PrimitiveConstantExpression(
-          new IntConstantValue(intValue)));
-    }
-
-    // DoubleConstant.
-    if (tag == "DoubleConstant") {
-      tokens.consumeStart();
-      tag = tokens.read();
-      double doubleValue = double.parse(tag, (_) => null);
-      if (doubleValue == null) {
-        throw "Invalid double value '$tag'.";
-      }
-      tokens.consumeEnd();
-      tokens.consumeEnd();
-      return new Constant(new PrimitiveConstantExpression(
-          new DoubleConstantValue(doubleValue)));
-    }
-
-    throw "Unhandled tag '$tag'.";
+    tokens.consumeEnd();
+    tokens.consumeEnd();
+    return result;
   }
 
   /// (CreateFunction (definition))
   CreateFunction parseCreateFunction() {
     tokens.consumeStart(CREATE_FUNCTION);
     FunctionDefinition def = parseFunctionDefinition();
     tokens.consumeEnd();
     return new CreateFunction(def);
   }
 
@@ skipping 41 matching lines @@
     return new ReifyTypeVar(type);
   }
 
   /// (This)
   This parseThis() {
     tokens.consumeStart(THIS);
     tokens.consumeEnd();
     return new This();
   }
 }