Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 81363002: Improve type test and type equality for generics (issue 15148). (Closed)

Created:
7 years, 1 month ago by regis
Modified:
7 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Improve type test and type equality for generics (issue 15148). R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=30546

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -74 lines) Patch
M runtime/vm/class_finalizer.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 4 chunks +21 lines, -18 lines 0 comments Download
M runtime/vm/object.cc View 1 11 chunks +64 lines, -41 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/const_list_test.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
Currently, the full flattened vector of a generic type is considered in a type test ...
7 years, 1 month ago (2013-11-21 18:41:53 UTC) #1
srdjan
lgtm
7 years, 1 month ago (2013-11-21 20:48:43 UTC) #2
regis
7 years, 1 month ago (2013-11-21 21:31:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r30546 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698