runtime/vm/flow_graph_compiler_ia32.cc - Issue 81363002: Improve type test and type equality for generics (issue 15148).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 81363002: Improve type test and type equality for generics (issue 15148). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

===================================================================

--- runtime/vm/flow_graph_compiler_ia32.cc (revision 30544)

+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)

@@ -243,10 +243,13 @@

} else {

__ j(ZERO, is_not_instance_lbl);

}

+ const intptr_t num_type_args = type_class.NumTypeArguments();

+ const intptr_t num_type_params = type_class.NumTypeParameters();

+ const intptr_t from_index = num_type_args - num_type_params;

const AbstractTypeArguments& type_arguments =

AbstractTypeArguments::ZoneHandle(type.arguments());

const bool is_raw_type = type_arguments.IsNull() ||

- type_arguments.IsRaw(type_arguments.Length());

+ type_arguments.IsRaw(from_index, num_type_params);

// Signature class is an instantiated parameterized type.

if (!type_class.IsSignatureClass()) {

if (is_raw_type) {

« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »