Issue 813603002: dart2js: Add a pointer from the emitter's JS code to the encoding part.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 813603002: dart2js: Add a pointer from the emitter's JS code to the encoding part. (Closed)

Created:
6 years ago by floitsch

Modified:
6 years ago

Reviewers:
karlklose

CC:
reviews_dartlang.org, zarah

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

dart2js: Add a pointer from the emitter's JS code to the encoding part. This makes it easier to understand how things are encoded and why the generated code must do these splits. (In Dart-editor a ctrl-click navigates to the comment and the code that encodes the data). R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=42440

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart	View		1 chunk	+12 lines, -1 line	0 comments	Download
	M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

karlklose

LGTM. We could make it even better by refactoring the js-emitter to use a builder ...

6 years ago (2014-12-17 09:17:53 UTC) #3

floitsch

6 years ago (2014-12-17 15:42:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42440 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages