Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart

Issue 813603002: dart2js: Add a pointer from the emitter's JS code to the encoding part. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 /** 7 /**
8 * A data structure for collecting fragments of a class definition. 8 * A data structure for collecting fragments of a class definition.
9 */ 9 */
10 class ClassBuilder { 10 class ClassBuilder {
(...skipping 16 matching lines...) Expand all
27 jsAst.Property addProperty(String name, jsAst.Expression value) { 27 jsAst.Property addProperty(String name, jsAst.Expression value) {
28 jsAst.Property property = new jsAst.Property(js.string(name), value); 28 jsAst.Property property = new jsAst.Property(js.string(name), value);
29 properties.add(property); 29 properties.add(property);
30 return property; 30 return property;
31 } 31 }
32 32
33 void addField(String field) { 33 void addField(String field) {
34 fields.add(field); 34 fields.add(field);
35 } 35 }
36 36
37 static String functionTypeEncodingDescription =
38 'For simple function types the function type is stored in the metadata '
39 'and the index is encoded into the superclass field.';
40
41 static String fieldEncodingDescription =
42 'Fields are encoded as a comma separated list. If there is a superclass '
43 '(and possibly a function type encoding) the fields are separated from '
44 'the superclass by a semicolon.';
45
37 jsAst.ObjectInitializer toObjectInitializer( 46 jsAst.ObjectInitializer toObjectInitializer(
38 {bool emitClassDescriptor: true}) { 47 {bool emitClassDescriptor: true}) {
39 StringBuffer buffer = new StringBuffer(); 48 StringBuffer buffer = new StringBuffer();
40 if (superName != null) { 49 if (superName != null) {
41 buffer.write('$superName'); 50 buffer.write(superName);
42 if (functionType != null) { 51 if (functionType != null) {
52 // See [functionTypeEncodingDescription] above.
43 buffer.write(':$functionType'); 53 buffer.write(':$functionType');
44 } 54 }
45 buffer.write(';'); 55 buffer.write(';');
46 } 56 }
57 // See [fieldEncodingDescription] above.
47 buffer.writeAll(fields, ','); 58 buffer.writeAll(fields, ',');
48 var classData = js.string('$buffer'); 59 var classData = js.string('$buffer');
49 if (fieldMetadata != null) { 60 if (fieldMetadata != null) {
50 // If we need to store fieldMetadata, classData is turned into an array, 61 // If we need to store fieldMetadata, classData is turned into an array,
51 // and the field metadata is appended. So if classData is just a string, 62 // and the field metadata is appended. So if classData is just a string,
52 // there is no field metadata. 63 // there is no field metadata.
53 classData = 64 classData =
54 new jsAst.ArrayInitializer([classData]..addAll(fieldMetadata)); 65 new jsAst.ArrayInitializer([classData]..addAll(fieldMetadata));
55 } 66 }
56 List<jsAst.Property> fieldsAndProperties; 67 List<jsAst.Property> fieldsAndProperties;
57 if (emitClassDescriptor) { 68 if (emitClassDescriptor) {
58 fieldsAndProperties = <jsAst.Property>[]; 69 fieldsAndProperties = <jsAst.Property>[];
59 fieldsAndProperties.add( 70 fieldsAndProperties.add(
60 new jsAst.Property( 71 new jsAst.Property(
61 js.string(namer.classDescriptorProperty), classData)); 72 js.string(namer.classDescriptorProperty), classData));
62 fieldsAndProperties.addAll(properties); 73 fieldsAndProperties.addAll(properties);
63 } else { 74 } else {
64 fieldsAndProperties = properties; 75 fieldsAndProperties = properties;
65 } 76 }
66 return new jsAst.ObjectInitializer(fieldsAndProperties, isOneLiner: false); 77 return new jsAst.ObjectInitializer(fieldsAndProperties, isOneLiner: false);
67 } 78 }
68 } 79 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698