Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 813203002: Add a few safe points for the debugger to stop (Closed)

Created:
6 years ago by hausner
Modified:
6 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add a few safe points for the debugger to stop Allow the debugger to stop on assignment of a closure to a local variable, and on a throw statement that throws a literal. Fixes issues 20762, 21352 R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=42516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M runtime/vm/flow_graph_builder.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
hausner
6 years ago (2014-12-19 00:23:24 UTC) #2
rmacnak
lgtm
6 years ago (2014-12-19 00:26:40 UTC) #3
hausner
Thank you.
6 years ago (2014-12-19 01:04:51 UTC) #4
hausner
6 years ago (2014-12-19 17:56:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r42516 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698