Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 813203002: Add a few safe points for the debugger to stop (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 42493)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -3410,7 +3410,8 @@
// a safe point for the debugger to stop, add an explicit stub
// call.
if (node->value()->IsLiteralNode() ||
- node->value()->IsLoadLocalNode()) {
+ node->value()->IsLoadLocalNode() ||
+ node->value()->IsClosureNode()) {
AddInstruction(new(I) DebugStepCheckInstr(
node->token_pos(), RawPcDescriptors::kRuntimeCall));
}
@@ -4193,6 +4194,12 @@
void EffectGraphVisitor::BuildThrowNode(ThrowNode* node) {
+ if (node->exception()->IsLiteralNode() ||
+ node->exception()->IsLoadLocalNode() ||
+ node->exception()->IsClosureNode()) {
+ AddInstruction(new(I) DebugStepCheckInstr(
+ node->token_pos(), RawPcDescriptors::kRuntimeCall));
+ }
ValueGraphVisitor for_exception(owner());
node->exception()->Visit(&for_exception);
Append(for_exception);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698