Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 812603004: dart2js: Remove builder dependency from type_test_generator. (Closed)

Created:
6 years ago by floitsch
Modified:
6 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, zarah
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

dart2js: Remove builder dependency from type_test_generator. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=42439

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename GeneratedTypeTests to TypeTestProperties. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -41 lines) Patch
M pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart View 1 1 chunk +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_generator.dart View 1 9 chunks +72 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
Next step: remove references to `oldEmitter`. After that we should be able to use the ...
6 years ago (2014-12-17 00:26:38 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/812603004/diff/1/pkg/compiler/lib/src/js_emitter/type_test_generator.dart File pkg/compiler/lib/src/js_emitter/type_test_generator.dart (right): https://codereview.chromium.org/812603004/diff/1/pkg/compiler/lib/src/js_emitter/type_test_generator.dart#newcode7 pkg/compiler/lib/src/js_emitter/type_test_generator.dart:7: class GeneratedTypeTests { How about 'TypeTestProperties'?
6 years ago (2014-12-17 13:31:19 UTC) #3
floitsch
https://codereview.chromium.org/812603004/diff/1/pkg/compiler/lib/src/js_emitter/type_test_generator.dart File pkg/compiler/lib/src/js_emitter/type_test_generator.dart (right): https://codereview.chromium.org/812603004/diff/1/pkg/compiler/lib/src/js_emitter/type_test_generator.dart#newcode7 pkg/compiler/lib/src/js_emitter/type_test_generator.dart:7: class GeneratedTypeTests { On 2014/12/17 13:31:19, karlklose wrote: > ...
6 years ago (2014-12-17 15:22:19 UTC) #4
floitsch
6 years ago (2014-12-17 15:22:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698