Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart

Issue 812603004: dart2js: Remove builder dependency from type_test_generator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rename GeneratedTypeTests to TypeTestProperties. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/type_test_generator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart
index b1727eaaaa8063c1cc49be40822cf95fba06e1ca..af0bd0ccbf0f6d07623f23f801679604cec7cf3a 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart
@@ -6,7 +6,13 @@ part of dart2js.js_emitter;
class TypeTestEmitter extends CodeEmitterHelper {
void emitIsTests(ClassElement classElement, ClassBuilder builder) {
- new TypeTestGenerator(compiler, emitter.task, namer)
- .emitIsTests(classElement, builder);
+ assert(builder.functionType == null);
+ TypeTestGenerator generator =
+ new TypeTestGenerator(compiler, emitter.task, namer);
+ TypeTestProperties typeTests = generator.generateIsTests(classElement);
+ typeTests.properties.forEach(builder.addProperty);
+ if (typeTests.functionTypeIndex != null) {
+ builder.functionType = '${typeTests.functionTypeIndex}';
+ }
}
-}
+}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/type_test_generator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698