insure type vars are bound properly when executing field initializers. Also correct assoc tablefor …

insure type vars are bound properly when executing field initializers. Also correct assoc tablefor ?:

R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42785

[gbracha, 2015-01-02 22:50:11]

gbracha@google.com changed reviewers:
+ lrn@google.com

[gbracha, 2015-01-02 22:50:11]

Per bug https://code.google.com/p/dart/issues/detail?id=21581.

[gbracha, 2015-01-03 00:41:40]

Updated a few more scope clarifications.

[Lasse Reichstein Nielsen, 2015-01-03 10:31:04]

lgtm

https://codereview.chromium.org/811953006/diff/20001/docs/language/dartLangSp...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/811953006/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:862: A class has a static scope and an instance
scope. The enclosing scope of the static scope of a non-generic class is the
enclosing scope of the class declaration. The enclosing scope of the static
scope of a generic class is the type parameter scope (\ref{generics}) of the
generic class declaration.
Could it be simpler to let all classes have a type parameter scope, even if it
is empty?

The "The .. of the .. of a ..." is hard to keep track of. Maybe rewrite as: 
---
For a non-generic class, the enclosing scope of the static scope is the
enclosing scope of the class declaration.
For a generic class, the enclosing scope of the static scope is the type
parameter scope (\ref{generics}) of the generic class declaration.
---

https://codereview.chromium.org/811953006/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:3288: A fresh instance
(\ref{generativeConstructors}), $i$,  of class $R$ is allocated. For each
instance variable $f$ of $i$,  if the variable declaration of $f$ has an
initializer expression $e_f$, then $e_f$ is evaluated, with the type parameters
(if any) of $R$ bound to the actual type arguments $V_1, \ldots, V_l$, to an
object $o_f$ and $f$ is bound to $o_f$. Otherwise $f$ is bound to \NULL{}.
Still doesn't say in which dynamic scope the expression is evaluated in.
It's the dynamic scope corresponding to the static parameter scope (or is it the
static class scope?).

https://codereview.chromium.org/811953006/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:7165: Conditional &  e1? e2: e3 & Right & 3\\
So it's Right because 
 x ? y : z ? w : v
is
 x ? y : (z ? w : v)
?

[gbracha, 2015-01-05 21:32:10]

PTAL

https://codereview.chromium.org/811953006/diff/20001/docs/language/dartLangSp...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/811953006/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:862: A class has a static scope and an instance
scope. The enclosing scope of the static scope of a non-generic class is the
enclosing scope of the class declaration. The enclosing scope of the static
scope of a generic class is the type parameter scope (\ref{generics}) of the
generic class declaration.
On 2015/01/03 10:31:04, Lasse Reichstein Nielsen wrote:
> Could it be simpler to let all classes have a type parameter scope, even if it
> is empty?
> 
> The "The .. of the .. of a ..." is hard to keep track of. Maybe rewrite as: 
> ---
> For a non-generic class, the enclosing scope of the static scope is the
> enclosing scope of the class declaration.
> For a generic class, the enclosing scope of the static scope is the type
> parameter scope (\ref{generics}) of the generic class declaration.
> ---
> 

Done.

https://codereview.chromium.org/811953006/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:3288: A fresh instance
(\ref{generativeConstructors}), $i$,  of class $R$ is allocated. For each
instance variable $f$ of $i$,  if the variable declaration of $f$ has an
initializer expression $e_f$, then $e_f$ is evaluated, with the type parameters
(if any) of $R$ bound to the actual type arguments $V_1, \ldots, V_l$, to an
object $o_f$ and $f$ is bound to $o_f$. Otherwise $f$ is bound to \NULL{}.
On 2015/01/03 10:31:04, Lasse Reichstein Nielsen wrote:
> Still doesn't say in which dynamic scope the expression is evaluated in.
> It's the dynamic scope corresponding to the static parameter scope (or is it
the
> static class scope?). 

All instance members are already said to be in the instance scope. Section 16.11
prevents the use of this in instance  initializers (among others).

https://codereview.chromium.org/811953006/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:7165: Conditional &  e1? e2: e3 & Right & 3\\
On 2015/01/03 10:31:04, Lasse Reichstein Nielsen wrote:
> So it's Right because 
>  x ? y : z ? w : v
> is
>  x ? y : (z ? w : v)
> ?

Yes

[Lasse Reichstein Nielsen, 2015-01-12 15:32:40]

lgtm

https://codereview.chromium.org/811953006/diff/40001/docs/language/dartLangSp...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/811953006/diff/40001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:526: \item {\bf Non-constant variable declaration
with initializer}. If $d$ is of one of the forms \code{\VAR{} $v$ = $e$;} , 
\code{$T$ $v$ = $e$;} ,   \code{\FINAL{} $v$ = $e$;} ,  \code{\FINAL{} $T$ $v$ =
$e$;}, \code{\STATIC{} $v$ = $e$; }, \code{\STATIC{} $T$ $v$ = $e$; },
\code{\STATIC{} \FINAL{} $v$ = $e$; } or \code{\STATIC{} \FINAL{} $T$ $v$ =
$e$;} and no value has yet been stored into $v$ then the initializer expression
$e$ is evaluated. If, during the evaluation of $e$, the getter for $v$ is
invoked, a \code{CyclicInitializationError} is thrown. If the evaluation
succeeded yielding an object $o$, let $r = o$, otherwise let $r = \NULL{}$. In
any case, $r$ is stored into $v$. The result of executing the getter is $r$.
Specify that the scope of evaluation of "e" is the static scope here? Or is that
covered somewhere else?
The scope of an instance member is said to be the instance scope below, but that
doesn't seem to apply to instance variable initializers, even if it applies to
the variable itself.

https://codereview.chromium.org/811953006/diff/40001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:864: \item A {\em type-parameter scope}, which is
empty if the class is not generic (\ref{generics}).  The enclosing scope of the
static scope of the type parameter scope of a class is the enclosing scope of
the class declaration.
Remove "the static scope of" here?

https://codereview.chromium.org/811953006/diff/40001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:865: \item A {\em static scope}. The enclosing
scope of the static scope of a  class is the type parameter scope
(\ref{generics}) of the class.
"type-parameter" with hyphen (for consistency with the other uses).

https://codereview.chromium.org/811953006/diff/40001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:1326: Execution of a generative constructor $k$
is always done with respect to a set of bindings for its formal parameters and
with  \THIS{} bound to a fresh instance $i$ and the type parameters of the
immediately enclosing class bound to a set of actual type arguments $V_1, \ldots
, V_m$.
Should it be said that the enclosing scope is the static scope?

[gbracha, 2015-01-12 18:52:28]

Committed patchset #4 (id:60001) manually as r42785 (presubmit successful).