Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 811933007: insert parameters when completing imported functions and inherited methods (Closed)

Created:
5 years, 11 months ago by danrubel
Modified:
5 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

insert parameters when completing imported functions and inherited methods BUG= R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=42808

Patch Set 1 #

Patch Set 2 : remove blank line #

Patch Set 3 : merge #

Total comments: 2

Messages

Total messages: 5 (1 generated)
danrubel
5 years, 11 months ago (2015-01-12 23:41:37 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/811933007/diff/40001/pkg/analysis_server/test/services/completion/completion_test_util.dart File pkg/analysis_server/test/services/completion/completion_test_util.dart (left): https://codereview.chromium.org/811933007/diff/40001/pkg/analysis_server/test/services/completion/completion_test_util.dart#oldcode1301 pkg/analysis_server/test/services/completion/completion_test_util.dart:1301: class I { int i1; i2() { } ...
5 years, 11 months ago (2015-01-13 00:02:48 UTC) #3
danrubel
Committed patchset #3 (id:40001) manually as 42808 (presubmit successful).
5 years, 11 months ago (2015-01-13 14:10:53 UTC) #4
danrubel
5 years, 11 months ago (2015-01-13 14:19:59 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/811933007/diff/40001/pkg/analysis_server/test...
File pkg/analysis_server/test/services/completion/completion_test_util.dart
(left):

https://codereview.chromium.org/811933007/diff/40001/pkg/analysis_server/test...
pkg/analysis_server/test/services/completion/completion_test_util.dart:1301:
class I { int i1; i2() { } get e1; }
On 2015/01/13 00:02:47, Paul Berry wrote:
> I'm curious why this getter was removed.

Oops. Forgot to add a comment about that. Done.

Powered by Google App Engine
This is Rietveld 408576698