insert parameters when completing imported functions and inherited methods

pkg/analysis_server/lib/src/services/completion/imported_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.toplevel;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/protocol_server.dart' hide Element,
@@ skipping 36 matching lines @@
       return builder.computeFull(request.node);
     }
     return new Future.value(false);
   }
 }
 
 /**
  * [_ImportedSuggestionBuilder] traverses the imports and builds suggestions
  * based upon imported elements.
  */
-class _ImportedSuggestionBuilder implements SuggestionBuilder {
+class _ImportedSuggestionBuilder extends ElementSuggestionBuilder implements
+    SuggestionBuilder {
   bool shouldWaitForLowPrioritySuggestions;
   final DartCompletionRequest request;
   final bool typesOnly;
   final bool excludeVoidReturn;
   DartCompletionCache cache;
 
   _ImportedSuggestionBuilder(this.request, {this.typesOnly: false,
       this.excludeVoidReturn: false}) {
     cache = request.cache;
   }
 
+  @override
+  CompletionSuggestionKind get kind => CompletionSuggestionKind.INVOCATION;
+
   /**
    * If the needed information is cached, then add suggestions and return `true`
    * else return `false` indicating that additional work is necessary.
    */
   bool computeFast(AstNode node) {
     CompilationUnit unit = request.unit;
     if (cache.isImportInfoCached(unit)) {
       _addInheritedSuggestions(node);
       _addTopLevelSuggestions();
       return true;
@@ skipping 28 matching lines @@
   /**
    * Add imported element suggestions.
    */
   void _addElementSuggestions(List<Element> elements) {
     elements.forEach((Element elem) {
       if (elem is! ClassElement) {
         if (typesOnly) {
           return;
         }
         if (elem is ExecutableElement) {
-          if (elem.isOperator) {
-            return;
-          }
           DartType returnType = elem.returnType;
           if (returnType != null && returnType.isVoid) {
             if (excludeVoidReturn) {
               return;
             }
           }
         }
-        if (elem.isSynthetic) {
-          if (elem is PropertyAccessorElement || elem is FieldElement) {
-            return;
-          }
-        }
       }
-      request.suggestions.add(
-          createElementSuggestion(elem, relevance: COMPLETION_RELEVANCE_DEFAULT));
+      addSuggestion(elem);
     });
   }
 
   /**
    * Add suggestions for any inherited imported members.
    */
   void _addInheritedSuggestions(AstNode node) {
     var classDecl = node.getAncestor((p) => p is ClassDeclaration);
     if (classDecl is ClassDeclaration) {
       // Build a list of inherited types that are imported
@@ skipping 56 matching lines @@
     addFilteredSuggestions(cache.importedTypeSuggestions);
     addFilteredSuggestions(cache.libraryPrefixSuggestions);
     if (!typesOnly) {
       addFilteredSuggestions(cache.otherImportedSuggestions);
       if (!excludeVoidReturn) {
         addFilteredSuggestions(cache.importedVoidReturnSuggestions);
       }
     }
   }
 }