Issue 811763003: cps-ir: Give up on code generation of static getters and setters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 811763003: cps-ir: Give up on code generation of static getters and setters. (Closed)

Created:
6 years ago by karlklose

Modified:
6 years ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

cps-ir: Give up on code generation of static getters and setters. They are currently encoded as [InvokeStatic]s, but we cannot generate code for them. We should create separate nodes for them and add type assertions for the elements. R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=42383

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View		3 chunks	+2 lines, -1 line	0 comments	Download
	M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

6 years ago (2014-12-16 10:29:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42383 (presubmit successful).

Expand Messages | Collapse Messages