Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart

Issue 811763003: cps-ir: Give up on code generation of static getters and setters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/codegen/codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
index 73d4afa3b6a9a7cbfd4fa1c164da9e24810198ff..928eeded6b9385d7c7c7756681d028abac2eba15 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart
@@ -6,7 +6,6 @@ library dart2js.ir_builder;
import '../constants/expressions.dart';
import '../constants/values.dart' show PrimitiveConstantValue;
-import '../dart_backend/dart_backend.dart' show DartBackend;
import '../dart_types.dart';
import '../dart2jslib.dart';
import '../elements/elements.dart';
@@ -695,6 +694,7 @@ class IrBuilder {
/// defined by [selector].
ir.Primitive buildStaticGet(Element element, Selector selector) {
assert(selector.isGetter);
+ // TODO(karlklose,sigurdm): build different nodes for getters.
return _buildInvokeStatic(element, selector, const <ir.Primitive>[]);
}
@@ -704,6 +704,7 @@ class IrBuilder {
Selector selector,
ir.Primitive value) {
assert(selector.isSetter);
+ // TODO(karlklose,sigurdm): build different nodes for setters.
_buildInvokeStatic(element, selector, <ir.Primitive>[value]);
return value;
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/codegen/codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698