Capture and report uncaught exceptions in server

Capture and report all exceptions in server

Committed: https://code.google.com/p/dart/source/detail?r=42509

[Brian Wilkerson, 2014-12-17 23:19:20]

brianwilkerson@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2014-12-18 18:57:38]

https://codereview.chromium.org/811223002/diff/1/pkg/analysis_server/lib/driv...
File pkg/analysis_server/lib/driver.dart (right):

https://codereview.chromium.org/811223002/diff/1/pkg/analysis_server/lib/driv...
pkg/analysis_server/lib/driver.dart:232: if (results[INTERNAL_PRINT_TO_CONSOLE])
{
Consider getting rid of the code duplication with:

_captureExceptions(() {
  stdioServer.serveStdio().then((_) {
    if (serve_http) {
      httpServer.close();
    }
    service.shutdown();
    exit(0);
  });
}, print: results[INTERNAL_PRINT_TO_CONSOLE] ? null : httpServer.recordPrint);

https://codereview.chromium.org/811223002/diff/1/pkg/analysis_server/lib/driv...
pkg/analysis_server/lib/driver.dart:268: print(line);
Won't this lead to a null reference exception if the client doesn't pass in a
print function?

I think you need to check whether the incoming "print" closure is null, and if
so, pass null to the constructor's "print" parameter.

[Brian Wilkerson, 2014-12-19 15:55:01]

https://codereview.chromium.org/811223002/diff/1/pkg/analysis_server/lib/driv...
File pkg/analysis_server/lib/driver.dart (right):

https://codereview.chromium.org/811223002/diff/1/pkg/analysis_server/lib/driv...
pkg/analysis_server/lib/driver.dart:232: if (results[INTERNAL_PRINT_TO_CONSOLE])
{
Done

https://codereview.chromium.org/811223002/diff/1/pkg/analysis_server/lib/driv...
pkg/analysis_server/lib/driver.dart:268: print(line);
Done

[Brian Wilkerson, 2014-12-19 15:55:40]

Committed patchset #1 (id:1) manually as 42509 (presubmit successful).