Capture and report uncaught exceptions in server

pkg/analysis_server/lib/driver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library driver;
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:analysis_server/http_server.dart';
@@ skipping 211 matching lines @@
     AnalysisEngine.instance.instrumentationService = service;
 
     socketServer = new SocketServer(analysisServerOptions, defaultSdk, service);
     httpServer = new HttpAnalysisServer(socketServer);
     stdioServer = new StdioAnalysisServer(socketServer);
 
     if (serve_http) {
       httpServer.serveHttp(port);
     }
 
     if (results[INTERNAL_PRINT_TO_CONSOLE]) {

[Paul Berry, 2014/12/18 18:57:38]

Consider getting rid of the code duplication with:

_captureExceptions(() {
  stdioServer.serveStdio().then((_) {
    if (serve_http) {
      httpServer.close();
    }
    service.shutdown();
    exit(0);
  });
}, print: results[INTERNAL_PRINT_TO_CONSOLE] ? null : httpServer.recordPrint);

[Brian Wilkerson, 2014/12/19 15:55:01]

Done

-      stdioServer.serveStdio().then((_) {
-        if (serve_http) {
-          httpServer.close();
-        }
-        service.shutdown();
-        exit(0);
-      });
-    } else {
-      _capturePrints(() {
+      _captureExceptions(() {
         stdioServer.serveStdio().then((_) {
           if (serve_http) {
             httpServer.close();
+          }
+          service.shutdown();
+          exit(0);
+        });
+      });
+    } else {
+      _captureExceptions(() {
+        stdioServer.serveStdio().then((_) {
+          if (serve_http) {
+            httpServer.close();
           }
           service.shutdown();
           exit(0);
         });
-      }, httpServer.recordPrint);
+      }, print: httpServer.recordPrint);
     }
   }
 
   /**
-   * Execute [callback], capturing any data it prints out and redirecting it to
-   * the function [printHandler].
+   * Execute the given [callback], capturing any unhandled exceptions and
+   * reporting them to the client. If a [printHandler] function is provided,
+   * then also capture any data printed by the callback and redirect it to the
+   * [printHandler].
    */
-  dynamic _capturePrints(dynamic callback(), void printHandler(String line)) {
+  dynamic _captureExceptions(dynamic callback(), {void print(String line)}) {
     ZoneSpecification zoneSpecification = new ZoneSpecification(
-        print: (Zone self, ZoneDelegate parent, Zone zone, String line) {
-      printHandler(line);
+        handleUncaughtError: (Zone self, ZoneDelegate parent, Zone zone,
+            dynamic exception, StackTrace stackTrace) {
+      socketServer.analysisServer.reportException(exception, stackTrace);
+      throw exception;
+    }, print: (Zone self, ZoneDelegate parent, Zone zone, String line) {
+      print(line);

[Paul Berry, 2014/12/18 18:57:38]

Won't this lead to a null reference exception if the client doesn't pass in a
print function?

I think you need to check whether the incoming "print" closure is null, and if
so, pass null to the constructor's "print" parameter.

[Brian Wilkerson, 2014/12/19 15:55:01]

Done

       // Note: we don't pass the line on to stdout, because that is reserved
       // for communication to the client.
     });
     return runZoned(callback, zoneSpecification: zoneSpecification);
   }
 
   /**
    * Print information about how to use the server.
    */
   void _printUsage(ArgParser parser) {
     print('Usage: $BINARY_NAME [flags]');
     print('');
     print('Supported flags are:');
     print(parser.usage);
   }
 }