Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 810593008: Mark mutator methods of canonical constants as invisible to reflective access. (Closed)

Created:
5 years, 11 months ago by regis
Modified:
5 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Mark mutator methods of canonical constants as invisible to reflective access. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=42747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M runtime/lib/bigint.dart View 1 chunk +1 line, -7 lines 0 comments Download
M runtime/lib/integers.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/lib/mirrors/invocation_fuzz_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
regis
5 years, 11 months ago (2015-01-09 03:08:13 UTC) #2
rmacnak
LGTM
5 years, 11 months ago (2015-01-09 18:02:07 UTC) #3
regis
5 years, 11 months ago (2015-01-09 18:03:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r42747 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698