runtime/vm/object.cc - Issue 810593008: Mark mutator methods of canonical constants as invisible to reflective access.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 810593008: Mark mutator methods of canonical constants as invisible to reflective access. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

===================================================================

--- runtime/vm/object.cc (revision 42724)

+++ runtime/vm/object.cc (working copy)

@@ -162,11 +162,17 @@

// The following functions are marked as invisible, meaning they will be hidden

// in the stack trace and will be hidden from reflective access.

+// All mutators of canonical constants should be hidden from reflective access.

// Additionally, private functions in dart:* that are native or constructors are

// marked as invisible by the parser.

#define INVISIBLE_CLASS_FUNCTIONS(V) \

V(AsyncLibrary, _AsyncRun, _scheduleImmediate) \

V(CoreLibrary, StringBuffer, _addPart) \

+ V(CoreLibrary, _Bigint, _setInt) \

+ V(CoreLibrary, _Bigint, _setHex) \

+ V(CoreLibrary, _Bigint, _setDouble) \

+ V(CoreLibrary, _Bigint, _ensureLength) \

+ V(CoreLibrary, _Bigint, _clamp) \

V(CoreLibrary, _Bigint, _absAdd) \

V(CoreLibrary, _Bigint, _absSub) \

V(CoreLibrary, _Bigint, _estQuotientDigit) \

« no previous file with comments | « runtime/vm/method_recognizer.h ('k') | tests/lib/mirrors/invocation_fuzz_test.dart » ('j') | no next file with comments »