Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 81013002: Cleanup the getting and setting of the socket file descriptor (Closed)

Created:
7 years, 1 month ago by Søren Gjesse
Modified:
7 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Cleanup the getting and setting of the socket file descriptor R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=30524

Patch Set 1 #

Patch Set 2 : Correctly rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -66 lines) Patch
M runtime/bin/eventhandler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process.cc View 1 chunk +8 lines, -12 lines 0 comments Download
M runtime/bin/socket.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/socket.cc View 14 chunks +34 lines, -51 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 1 month ago (2013-11-21 14:39:10 UTC) #1
Anders Johnsen
LGTM (minus your previous commit).
7 years, 1 month ago (2013-11-21 15:00:40 UTC) #2
Søren Gjesse
Rebased without previous change.
7 years, 1 month ago (2013-11-21 15:17:43 UTC) #3
Søren Gjesse
7 years, 1 month ago (2013-11-21 15:22:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r30524 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698