Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 809483005: dart2js: Move type_test_emitter. (Closed)

Created:
6 years ago by floitsch
Modified:
6 years ago
Reviewers:
karlklose, zarah
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -217 lines) Patch
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart View 1 chunk +3 lines, -210 lines 0 comments Download
A + pkg/compiler/lib/src/js_emitter/type_test_generator.dart View 3 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
Next step: remove references to the classBuilder from type_test_generator and move them back to the ...
6 years ago (2014-12-16 14:16:00 UTC) #2
zarah
LGTM
6 years ago (2014-12-17 08:45:44 UTC) #3
karlklose
LGTM.
6 years ago (2014-12-17 09:16:03 UTC) #4
floitsch
6 years ago (2014-12-17 15:07:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42436 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698