Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart

Issue 809483005: dart2js: Move type_test_emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart
index 2607581268d4937a88856faab15e5e47c7f0a7b7..b1727eaaaa8063c1cc49be40822cf95fba06e1ca 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart
@@ -5,215 +5,8 @@
part of dart2js.js_emitter;
class TypeTestEmitter extends CodeEmitterHelper {
- Set<ClassElement> get checkedClasses =>
- emitter.typeTestRegistry.checkedClasses;
-
- Iterable<ClassElement> get classesUsingTypeVariableTests =>
- emitter.typeTestRegistry.classesUsingTypeVariableTests;
-
- Set<FunctionType> get checkedFunctionTypes =>
- emitter.typeTestRegistry.checkedFunctionTypes;
-
void emitIsTests(ClassElement classElement, ClassBuilder builder) {
- assert(invariant(classElement, classElement.isDeclaration));
-
- void generateIsTest(Element other) {
- if (other == compiler.objectClass && other != classElement) {
- // Avoid emitting `$isObject` on all classes but [Object].
- return;
- }
- builder.addProperty(namer.operatorIs(other), js('true'));
- }
-
- void generateFunctionTypeSignature(FunctionElement method,
- FunctionType type) {
- assert(method.isImplementation);
- jsAst.Expression thisAccess = new jsAst.This();
- Node node = method.node;
- ClosureClassMap closureData =
- compiler.closureToClassMapper.closureMappingCache[node];
- if (closureData != null) {
- ClosureFieldElement thisLocal =
- closureData.getFreeVariableElement(closureData.thisLocal);
- if (thisLocal != null) {
- String thisName = namer.instanceFieldPropertyName(thisLocal);
- thisAccess = js('this.#', thisName);
- }
- }
- RuntimeTypes rti = backend.rti;
- jsAst.Expression encoding = rti.getSignatureEncoding(type, thisAccess);
- String operatorSignature = namer.operatorSignature;
- if (!type.containsTypeVariables) {
- builder.functionType = '${emitter.metadataEmitter.reifyType(type)}';
- } else {
- builder.addProperty(operatorSignature, encoding);
- }
- }
-
- void generateSubstitution(ClassElement cls, {bool emitNull: false}) {
- if (cls.typeVariables.isEmpty) return;
- RuntimeTypes rti = backend.rti;
- jsAst.Expression expression;
- bool needsNativeCheck = emitter.nativeEmitter.requiresNativeIsCheck(cls);
- expression = rti.getSupertypeSubstitution(classElement, cls);
- if (expression == null && (emitNull || needsNativeCheck)) {
- expression = new jsAst.LiteralNull();
- }
- if (expression != null) {
- builder.addProperty(namer.substitutionName(cls), expression);
- }
- }
-
- void generateTypeCheck(TypeCheck check) {
- ClassElement checkedClass = check.cls;
- // We must not call [generateIsTest] since we also want is$Object.
- builder.addProperty(namer.operatorIs(checkedClass), js('true'));
- Substitution substitution = check.substitution;
- if (substitution != null) {
- jsAst.Expression body = substitution.getCode(backend.rti);
- builder.addProperty(namer.substitutionName(checkedClass), body);
- }
- }
-
- generateIsTestsOn(classElement, generateIsTest,
- generateFunctionTypeSignature,
- generateSubstitution,
- generateTypeCheck);
- }
-
- /**
- * Generate "is tests" for [cls] itself, and the "is tests" for the
- * classes it implements and type argument substitution functions for these
- * tests. We don't need to add the "is tests" of the super class because
- * they will be inherited at runtime, but we may need to generate the
- * substitutions, because they may have changed.
- */
- void generateIsTestsOn(ClassElement cls,
- void emitIsTest(Element element),
- FunctionTypeSignatureEmitter emitFunctionTypeSignature,
- SubstitutionEmitter emitSubstitution,
- void emitTypeCheck(TypeCheck check)) {
- Setlet<Element> generated = new Setlet<Element>();
-
- if (checkedClasses.contains(cls)) {
- emitIsTest(cls);
- emitSubstitution(cls);
- generated.add(cls);
- }
-
- // Precomputed is checks.
- TypeChecks typeChecks = backend.rti.requiredChecks;
- Iterable<TypeCheck> classChecks = typeChecks[cls];
- if (classChecks != null) {
- for (TypeCheck check in classChecks) {
- if (!generated.contains(check.cls)) {
- emitTypeCheck(check);
- generated.add(check.cls);
- }
- }
- }
-
- RuntimeTypes rti = backend.rti;
- ClassElement superclass = cls.superclass;
-
- bool haveSameTypeVariables(ClassElement a, ClassElement b) {
- if (a.isClosure) return true;
- return backend.rti.isTrivialSubstitution(a, b);
- }
-
- if (superclass != null && superclass != compiler.objectClass &&
- !haveSameTypeVariables(cls, superclass)) {
- // We cannot inherit the generated substitutions, because the type
- // variable layout for this class is different. Instead we generate
- // substitutions for all checks and make emitSubstitution a NOP for the
- // rest of this function.
-
- // TODO(karlklose): move the computation of these checks to
- // RuntimeTypeInformation.
- while (superclass != null) {
- if (backend.classNeedsRti(superclass)) {
- emitSubstitution(superclass, emitNull: true);
- generated.add(superclass);
- }
- superclass = superclass.superclass;
- }
- for (DartType supertype in cls.allSupertypes) {
- ClassElement superclass = supertype.element;
- if (generated.contains(superclass)) continue;
-
- if (classesUsingTypeVariableTests.contains(superclass) ||
- checkedClasses.contains(superclass)) {
- // Generate substitution. If no substitution is necessary, emit
- // `null` to overwrite a (possibly) existing substitution from the
- // super classes.
- emitSubstitution(superclass, emitNull: true);
- }
- }
-
- void emitNothing(_, {emitNull}) {};
-
- emitSubstitution = emitNothing;
- }
-
- // A class that defines a `call` method implicitly implements
- // [Function] and needs checks for all typedefs that are used in is-checks.
- if (checkedClasses.contains(compiler.functionClass) ||
- checkedFunctionTypes.isNotEmpty) {
- Element call = cls.lookupLocalMember(Compiler.CALL_OPERATOR_NAME);
- if (call == null) {
- // If [cls] is a closure, it has a synthetic call operator method.
- call = cls.lookupBackendMember(Compiler.CALL_OPERATOR_NAME);
- }
- if (call != null && call.isFunction) {
- // A superclass might already implement the Function interface. In such
- // a case, we can avoid emiting the is test here.
- if (!cls.superclass.implementsFunction(compiler)) {
- generateInterfacesIsTests(compiler.functionClass,
- emitIsTest,
- emitSubstitution,
- generated);
- }
- FunctionType callType = call.computeType(compiler);
- emitFunctionTypeSignature(call, callType);
- }
- }
-
- for (DartType interfaceType in cls.interfaces) {
- generateInterfacesIsTests(interfaceType.element, emitIsTest,
- emitSubstitution, generated);
- }
- }
-
- /**
- * Generate "is tests" where [cls] is being implemented.
- */
- void generateInterfacesIsTests(ClassElement cls,
- void emitIsTest(ClassElement element),
- SubstitutionEmitter emitSubstitution,
- Set<Element> alreadyGenerated) {
- void tryEmitTest(ClassElement check) {
- if (!alreadyGenerated.contains(check) && checkedClasses.contains(check)) {
- alreadyGenerated.add(check);
- emitIsTest(check);
- emitSubstitution(check);
- }
- };
-
- tryEmitTest(cls);
-
- for (DartType interfaceType in cls.interfaces) {
- Element element = interfaceType.element;
- tryEmitTest(element);
- generateInterfacesIsTests(element, emitIsTest, emitSubstitution,
- alreadyGenerated);
- }
-
- // We need to also emit "is checks" for the superclass and its supertypes.
- ClassElement superclass = cls.superclass;
- if (superclass != null) {
- tryEmitTest(superclass);
- generateInterfacesIsTests(superclass, emitIsTest, emitSubstitution,
- alreadyGenerated);
- }
+ new TypeTestGenerator(compiler, emitter.task, namer)
+ .emitIsTests(classElement, builder);
}
-}
+}
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/js_emitter.dart ('k') | pkg/compiler/lib/src/js_emitter/type_test_generator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698