dart2js: is-checks for the new emitter.

dart2js: is-checks for the new emitter.

Also includes more fine-grained access to classes.

R=johnniwinther@google.com, kasperl@google.com, zarah@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42587

[floitsch, 2015-01-02 12:55:40]

floitsch@google.com changed reviewers:
+ kasperl@google.com, zarah@google.com

[zarah, 2015-01-02 15:58:50]

LGTM

[kasperl, 2015-01-05 08:19:09]

LGTM.

https://codereview.chromium.org/809433004/diff/40001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/809433004/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/program_builder.dart:287:
typeTests.properties.forEach((String name, js.Node code) {
You could consider a combination of keys.map/addAll here.

[Johnni Winther, 2015-01-05 08:56:04]

johnniwinther@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2015-01-05 08:56:05]

lgtm

[floitsch, 2015-01-05 10:42:11]

https://codereview.chromium.org/809433004/diff/40001/pkg/compiler/lib/src/js_...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/809433004/diff/40001/pkg/compiler/lib/src/js_...
pkg/compiler/lib/src/js_emitter/program_builder.dart:287:
typeTests.properties.forEach((String name, js.Node code) {
On 2015/01/05 08:19:09, kasperl wrote:
> You could consider a combination of keys.map/addAll here.

I don't see any good way without doing a hashtable lookup for every element.
The for-each has the advantage that it just runs through its elements without
needing to do any hashing...

[floitsch, 2015-01-05 11:33:47]

Committed patchset #3 (id:40001) manually as 42587 (presubmit successful).