Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 809433004: dart2js: is-checks for the new emitter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Improved test. Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/codegen.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart
index 7207d6812d4ef766a9d20a905c6dac6450c50f23..4c97c464adcaf3c91da6339ce6fe6fda4845645d 100644
--- a/pkg/compiler/lib/src/ssa/codegen.dart
+++ b/pkg/compiler/lib/src/ssa/codegen.dart
@@ -1681,8 +1681,9 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
assert(invariant(node, compiler.hasIncrementalSupport));
methodName = backend.namer.getNameOfInstanceMember(superMethod);
}
- push(js.js('#.prototype.#.call(#)',
- [backend.emitter.classAccess(superClass),
+ push(js.js('#.#.call(#)',
+ [backend.emitter.prototypeAccess(superClass,
+ hasBeenInstantiated: true),
methodName, visitArguments(node.inputs, start: 0)]),
node);
} else {
@@ -1786,7 +1787,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
visitForeignNew(HForeignNew node) {
js.Expression jsClassReference =
- backend.emitter.classAccess(node.element);
+ backend.emitter.constructorAccess(node.element);
List<js.Expression> arguments = visitArguments(node.inputs, start: 0);
push(new js.New(jsClassReference, arguments), node);
registerForeignTypes(node);
@@ -2633,7 +2634,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
}
ClassElement cls = node.dartType.element;
- var arguments = [backend.emitter.classAccess(cls)];
+ var arguments = [backend.emitter.typeAccess(cls)];
if (!typeArguments.isEmpty) {
arguments.add(new js.ArrayInitializer(typeArguments));
}

Powered by Google App Engine
This is Rietveld 408576698