Avoid unneeded toLowerCase and add fast version of _isTokenChar, in HTTP parser.

Avoid unneeded toLowerCase and add fast version of _isTokenChar, in HTTP parser.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30517

[Søren Gjesse, 2013-11-21 13:03:03]

lgtm

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_headers.dart#...
sdk/lib/io/http_headers.dart:132: if (chunkedTransferEncoding)
chunkedTransferEncoding = false;
Accidental edit?

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:21: static const SEPARATORS = const [40, 41, 60, 62,
64, 44, 59, 58, 92, 34, 47,
Is SEPARATORS still used?

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:24: // Loopup-map for _isTokenChar.
Add the character-list from above to the comment.

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:25: static const CHAR_MAP = const [
CHAR_MAP -> TOKEN_CHAR_MAP

[Anders Johnsen, 2013-11-21 13:14:41]

PTAL, did a bit of cleanup.

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_headers.dart
File sdk/lib/io/http_headers.dart (right):

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_headers.dart#...
sdk/lib/io/http_headers.dart:132: if (chunkedTransferEncoding)
chunkedTransferEncoding = false;
On 2013/11/21 13:03:03, Søren Gjesse wrote:
> Accidental edit?

Done.

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_parser.dart
File sdk/lib/io/http_parser.dart (right):

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:21: static const SEPARATORS = const [40, 41, 60, 62,
64, 44, 59, 58, 92, 34, 47,
On 2013/11/21 13:03:03, Søren Gjesse wrote:
> Is SEPARATORS still used?

Done.

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:24: // Loopup-map for _isTokenChar.
On 2013/11/21 13:03:03, Søren Gjesse wrote:
> Add the character-list from above to the comment.

Done.

https://codereview.chromium.org/80883002/diff/1/sdk/lib/io/http_parser.dart#n...
sdk/lib/io/http_parser.dart:25: static const CHAR_MAP = const [
On 2013/11/21 13:03:03, Søren Gjesse wrote:
> CHAR_MAP -> TOKEN_CHAR_MAP

Done.

[Søren Gjesse, 2013-11-21 13:20:33]

lgtm

[Anders Johnsen, 2013-11-21 13:21:38]

Committed patchset #3 manually as r30517 (presubmit successful).