Avoid unneeded toLowerCase and add fast version of _isTokenChar, in HTTP parser.

sdk/lib/io/http_parser.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 // Global constants.
 class _Const {
   // Bytes for "HTTP".
   static const HTTP = const [72, 84, 84, 80];
   // Bytes for "HTTP/1.".
   static const HTTP1DOT = const [72, 84, 84, 80, 47, 49, 46];
   // Bytes for "HTTP/1.0".
   static const HTTP10 = const [72, 84, 84, 80, 47, 49, 46, 48];
   // Bytes for "HTTP/1.1".
   static const HTTP11 = const [72, 84, 84, 80, 47, 49, 46, 49];
 
   static const END_CHUNKED = const [0x30, 13, 10, 13, 10];
 
   // Bytes for '()<>@,;:\\"/[]?={} \t'.
   static const SEPARATORS = const [40, 41, 60, 62, 64, 44, 59, 58, 92, 34, 47,

[Søren Gjesse, 2013/11/21 13:03:03]

Is SEPARATORS still used?

[Anders Johnsen, 2013/11/21 13:14:41]

Done.

                                    91, 93, 63, 61, 123, 125, 32, 9];
 
+  // Loopup-map for _isTokenChar.

[Søren Gjesse, 2013/11/21 13:03:03]

Add the character-list from above to the comment.

[Anders Johnsen, 2013/11/21 13:14:41]

Done.

+  static const CHAR_MAP = const [

[Søren Gjesse, 2013/11/21 13:03:03]

CHAR_MAP -> TOKEN_CHAR_MAP

[Anders Johnsen, 2013/11/21 13:14:41]

Done.

+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,true,false,true,
+      true,true,true,true,false,false,true,true,false,true,true,false,true,true,
+      true,true,true,true,true,true,true,true,false,false,false,false,false,
+      false,false,true,true,true,true,true,true,true,true,true,true,true,true,
+      true,true,true,true,true,true,true,true,true,true,true,true,true,true,
+      false,false,false,true,true,true,true,true,true,true,true,true,true,true,
+      true,true,true,true,true,true,true,true,true,true,true,true,true,true,
+      true,true,true,true,false,true,false,true,true,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false,false,false,false,false,false,false,false,false,
+      false,false,false,false];
+
   // Bytes for '()<>@,;:\\"/[]?={} \t\r\n'.
   static const SEPARATORS_AND_CR_LF = const [40, 41, 60, 62, 64, 44, 59, 58, 92,
                                              34, 47, 91, 93, 63, 61, 123, 125,
                                              32, 9, 13, 10];
 }
 
 
 // Frequently used character codes.
 class _CharCode {
   static const int HT = 9;
@@ skipping 794 matching lines @@
     _remainingContent = -1;
 
     _headers = null;
   }
 
   _releaseBuffer() {
     _buffer = null;
     _index = null;
   }
 
-  bool _isTokenChar(int byte) {
-    return byte > 31 && byte < 128 && _Const.SEPARATORS.indexOf(byte) == -1;
-  }
+  bool _isTokenChar(int byte) => _Const.CHAR_MAP[byte];
 
   List<String> _tokenizeFieldValue(String headerValue) {
     List<String> tokens = new List<String>();
     int start = 0;
     int index = 0;
     while (index < headerValue.length) {
       if (headerValue[index] == ",") {
         tokens.add(headerValue.substring(start, index));
         start = index + 1;
       } else if (headerValue[index] == " " || headerValue[index] == "\t") {
@@ skipping 132 matching lines @@
   _HttpHeaders _headers;
 
   // The current incoming connection.
   _HttpIncoming _incoming;
   StreamSubscription _socketSubscription;
   bool _paused = true;
   bool _bodyPaused = false;
   StreamController<_HttpIncoming> _controller;
   StreamController<List<int>> _bodyController;
 }