Issue 807813004: Retry up to 4 times on safari until we have a resolution for issue 21434

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 807813004: Retry up to 4 times on safari until we have a resolution for issue 21434 (Closed)

Created:
6 years ago by ricow1

Modified:
5 years, 3 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Retry up to 4 times on safari until we have a resolution for issue 21434 I worry more that people will actually ignore these then retrying it for now.

Patch Set 1 #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	tools/testing/dart/test_runner.dart	View		2 chunks	+3 lines, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/807813004/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/807813004/diff/1/tools/testing/dart/test_runner.dart#newcode157 tools/testing/dart/test_runner.dart:157: if (true) return new Future.value(false); debug?

6 years ago (2014-12-17 09:55:25 UTC) #2

ricow1

https://codereview.chromium.org/807813004/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/807813004/diff/1/tools/testing/dart/test_runner.dart#newcode157 tools/testing/dart/test_runner.dart:157: if (true) return new Future.value(false); On 2014/12/17 09:55:25, floitsch ...

6 years ago (2014-12-17 09:57:14 UTC) #3

ricow1

6 years ago (2014-12-17 09:57:15 UTC) #4

Committed patchset #1 (id:1) manually as r42424 (presubmit successful).

Expand Messages | Collapse Messages