Retry up to 4 times on safari until we have a resolution for issue 21434

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 136 matching lines @@
   CompilationCommand._(String displayName,
                        this._outputFile,
                        this._neverSkipCompilation,
                        this._bootstrapDependencies,
                        String executable,
                        List<String> arguments,
                        Map<String, String> environmentOverrides)
       : super._(displayName, executable, arguments, environmentOverrides);
 
   Future<bool> get outputIsUpToDate {
-    if (_neverSkipCompilation) return new Future.value(false);
+    if (true) return new Future.value(false);

[floitsch, 2014/12/17 09:55:25]

debug?

[ricow1, 2014/12/17 09:57:14]

yes, thanks

 
     Future<List<Uri>> readDepsFile(String path) {
       var file = new io.File(new Path(path).toNativePath());
       if (!file.existsSync()) {
         return new Future.value(null);
       }
       return file.readAsLines().then((List<String> lines) {
         var dependencies = new List<Uri>();
         for (var line in lines) {
           line = line.trim();
@@ skipping 118 matching lines @@
       identical(configuration, other.configuration) &&
       retry == other.retry;
 
   String get reproductionCommand {
     var parts = [TestUtils.dartTestExecutable.toString(),
                 'tools/testing/dart/launch_browser.dart',
                 browser,
                 url];
     return parts.map(escapeCommandLineArgument).join(' ');
   }
+
+  int get maxNumRetries => 4;
 }
 
 class BrowserHtmlTestCommand extends BrowserTestCommand {
   List<String> expectedMessages;
   BrowserHtmlTestCommand._(String browser,
                            String url,
                            Map configuration,
                            this.expectedMessages,
                            bool retry)
       : super._(browser, url, configuration, retry);
@@ skipping 2642 matching lines @@
     }
   }
 
   void eventAllTestsDone() {
     for (var listener in _eventListener) {
       listener.allDone();
     }
     _allDone();
   }
 }