Fix getAnalysisContextForSource.

Fix getAnalysisContextForSource.

Previously this function was always returning the first context; as a
result completions were only being precomputed for the first context.

There were probably subtle breakages in other features as well, though
I'm not aware of any specific problems.

R=danrubel@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42401

[Paul Berry, 2014-12-15 19:54:15]

paulberry@google.com changed reviewers:
+ danrubel@google.com

[Brian Wilkerson, 2014-12-15 20:26:52]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2014-12-15 20:26:53]

https://codereview.chromium.org/805783004/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/805783004/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:300: if (kind !=
SourceKind.UNKNOWN) {
I don't think this is adequate. Let's discuss.

Also, it would be good to add tests to ensure that this won't be broken again.

[danrubel, 2014-12-15 20:37:09]

+1 for a new test

[danrubel, 2014-12-16 08:05:44]

Per discussion LGTM

[Paul Berry, 2014-12-16 17:08:03]

On 2014/12/15 20:26:53, Brian Wilkerson wrote:
>
https://codereview.chromium.org/805783004/diff/1/pkg/analysis_server/lib/src/...
> File pkg/analysis_server/lib/src/analysis_server.dart (right):
> 
>
https://codereview.chromium.org/805783004/diff/1/pkg/analysis_server/lib/src/...
> pkg/analysis_server/lib/src/analysis_server.dart:300: if (kind !=
> SourceKind.UNKNOWN) {
> I don't think this is adequate. Let's discuss.
> 
> Also, it would be good to add tests to ensure that this won't be broken again.

Ok, after discussion it looks like this is an improvement but there is certainly
more work to do.  I will go ahead and land the CL now, and I'll file a ticket
explaining what work still needs to be done.

In a follow-up CL, I'll add tests to (a) ensure that this doesn't get broken
again, and (b) demonstrate the ways in which this fix is not yet sufficient.

[Paul Berry, 2014-12-16 17:11:30]

Committed patchset #1 (id:1) manually as 42401 (presubmit successful).