Fix getAnalysisContextForSource.

pkg/analysis_server/lib/src/analysis_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analysis.server;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/analysis_logger.dart';
@@ skipping 279 matching lines @@
     return getAnalysisContextForSource(getSource(path));
   }
 
   /**
    * Return the [AnalysisContext] that is used to analyze the given [source].
    * Return `null` if there is no such context.
    */
   AnalysisContext getAnalysisContextForSource(Source source) {
     for (AnalysisContext context in folderMap.values) {
       SourceKind kind = context.getKindOf(source);
-      if (kind != null) {
+      if (kind != SourceKind.UNKNOWN) {

[Brian Wilkerson, 2014/12/15 20:26:53]

I don't think this is adequate. Let's discuss.

Also, it would be good to add tests to ensure that this won't be broken again.

         return context;
       }
     }
     return null;
   }
 
   /**
    * Return the [AnalysisContext]s that are being used to analyze the analysis
    * roots.
    */
@@ skipping 756 matching lines @@
    * [packageUriResolver].
    */
   SourceFactory _createSourceFactory(UriResolver packageUriResolver) {
     List<UriResolver> resolvers = <UriResolver>[
         new DartUriResolver(analysisServer.defaultSdk),
         new ResourceUriResolver(resourceProvider),
         packageUriResolver];
     return new SourceFactory(resolvers);
   }
 }