Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 802233002: refine when suggestions are limited to types (Closed)

Created:
6 years ago by danrubel
Modified:
6 years ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

refine when suggestions are limited to types BUG=dartbug.com/18860 R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=42366

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Patch Set 3 : merge and address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 1 2 1 chunk +16 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 1 2 1 chunk +13 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 2 chunks +77 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
6 years ago (2014-12-15 03:24:48 UTC) #2
Paul Berry
lgtm once code duplication is addressed https://codereview.chromium.org/802233002/diff/1/pkg/analysis_server/lib/src/services/completion/local_computer.dart File pkg/analysis_server/lib/src/services/completion/local_computer.dart (right): https://codereview.chromium.org/802233002/diff/1/pkg/analysis_server/lib/src/services/completion/local_computer.dart#newcode311 pkg/analysis_server/lib/src/services/completion/local_computer.dart:311: // then limit ...
6 years ago (2014-12-15 16:32:19 UTC) #3
danrubel
Committed patchset #3 (id:40001) manually as 42366 (presubmit successful).
6 years ago (2014-12-15 17:48:08 UTC) #4
danrubel
6 years ago (2014-12-16 08:04:59 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/802233002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/local_computer.dart
(right):

https://codereview.chromium.org/802233002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/local_computer.dart:311: // then
limit suggestions to only types in specific situations
On 2014/12/15 16:32:19, Paul Berry wrote:
> The logic here looks exactly the same as the corresponding logic in the last
> file.  Can we share the code rather than duplicating it?

Per discussion, I added a TODO here and will address it in a subsequent CL.

Powered by Google App Engine
This is Rietveld 408576698