refine when suggestions are limited to types

pkg/analysis_server/lib/src/services/completion/local_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.local;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart' as protocol show Element,
     ElementKind;
@@ skipping 290 matching lines @@
 
   @override
   bool visitStringLiteral(StringLiteral node) {
     // ignore
     return finished;
   }
 
   @override
   visitTypeName(TypeName node) {
     // If suggesting completions within a TypeName node
-    // then limit suggestions to only types
-    typesOnly = true;
+    // then limit suggestions to only types in specific situations

[Paul Berry, 2014/12/15 16:32:19]

The logic here looks exactly the same as the corresponding logic in the last
file.  Can we share the code rather than duplicating it?

[danrubel, 2014/12/16 08:04:59]

Per discussion, I added a TODO here and will address it in a subsequent CL.

+    AstNode p = node.parent;
+    if (p is IsExpression || p is ConstructorName || p is AsExpression) {
+      typesOnly = true;
+    } else if (p is VariableDeclarationList) {
+      // TODO (danrubel) When entering 1st of 2 identifiers on assignment LHS
+      // the user may be either (1) entering a type for the assignment
+      // or (2) starting a new statement.
+      // Consider suggesting only types
+      // if only spaces separates the 1st and 2nd identifiers.
+    }
     return visitNode(node);
   }
 
   @override
   bool visitVariableDeclaration(VariableDeclaration node) {
     // Do not add suggestions if editing the name in a var declaration
     SimpleIdentifier name = node.name;
     if (name == null || name.offset < offset || offset > name.end) {
       return visitNode(node);
     } else {
@@ skipping 112 matching lines @@
     if (name == null || name.length <= 0) {
       return DYNAMIC;
     }
     TypeArgumentList typeArgs = type.typeArguments;
     if (typeArgs != null) {
       //TODO (danrubel) include type arguments
     }
     return name;
   }
 }