Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 802023002: Fix SLTIU instruction in MIPS assembler, disassembler, and simulator. (Closed)

Created:
6 years ago by regis
Modified:
6 years ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix SLTIU instruction in MIPS assembler, disassembler, and simulator. Add regression assembler test. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=42362

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -11 lines) Patch
M runtime/vm/assembler_mips.h View 4 chunks +9 lines, -6 lines 1 comment Download
M runtime/vm/assembler_mips_test.cc View 2 chunks +35 lines, -1 line 0 comments Download
M runtime/vm/disassembler_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_mips.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
regis
Good that we do not use this instruction too much so far :-) My new ...
6 years ago (2014-12-13 01:28:26 UTC) #2
regis
Mmm, STLIU -> SLTIU That was not the bug
6 years ago (2014-12-13 01:33:17 UTC) #3
zra
lgtm https://codereview.chromium.org/802023002/diff/1/runtime/vm/assembler_mips.h File runtime/vm/assembler_mips.h (right): https://codereview.chromium.org/802023002/diff/1/runtime/vm/assembler_mips.h#newcode714 runtime/vm/assembler_mips.h:714: void sltiu(Register rt, Register rs, const Immediate& imm) ...
6 years ago (2014-12-13 03:12:59 UTC) #4
regis
Not intuitive, for sure. But it allows to express values near the minimum and near ...
6 years ago (2014-12-15 16:45:15 UTC) #5
regis
6 years ago (2014-12-15 16:46:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r42362.

Powered by Google App Engine
This is Rietveld 408576698