Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 798643003: Pass condition result explicitly. Do not imply the existence of a status (Closed)

Created:
6 years ago by regis
Modified:
6 years ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Pass condition result explicitly. Do not imply the existence of a status register. MIPS does not have one. This is in preparation of another cl improving generated code for conditional expressions and branches on MIPS. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=42346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -136 lines) Patch
M runtime/vm/flow_graph_compiler.h View 1 chunk +8 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 3 chunks +15 lines, -12 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 3 chunks +15 lines, -12 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 4 chunks +15 lines, -12 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 5 chunks +18 lines, -13 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 4 chunks +16 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +17 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +17 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +17 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +17 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +17 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
regis
This cl does not change generated code, but will allow for better code on MIPS ...
6 years ago (2014-12-12 00:10:13 UTC) #8
srdjan
6 years ago (2014-12-12 00:13:44 UTC) #10
srdjan
lgtm
6 years ago (2014-12-12 21:09:57 UTC) #11
regis
6 years ago (2014-12-12 21:12:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r42346 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698