Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 798173004: Add filtering to completion tests. (Closed)

Created:
6 years ago by Paul Berry
Modified:
6 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add filtering to completion tests. This allows the negative completion tests to be run. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42432

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -40 lines) Patch
M pkg/analysis_server/test/completion_test.dart View 25 chunks +48 lines, -34 lines 0 comments Download
M pkg/analysis_server/test/completion_test_support.dart View 5 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years ago (2014-12-17 03:20:15 UTC) #2
scheglov
lgtm
6 years ago (2014-12-17 06:01:54 UTC) #3
Paul Berry
6 years ago (2014-12-17 14:42:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42432 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698