Add filtering to completion tests.

pkg/analysis_server/test/completion_test_support.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.completion.support;
 
+import 'dart:async';
 import 'dart:collection';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analyzer/src/generated/java_core.dart';
 import 'package:unittest/unittest.dart';
 
 import 'domain_completion_test.dart';
-import 'dart:async';
 
 /**
  * A base class for classes containing completion tests.
  */
 class CompletionTestCase extends CompletionTest {
   static const String CURSOR_MARKER = '!';
 
   List get suggestedCompletions =>
       suggestions.map(
           (CompletionSuggestion suggestion) => suggestion.completion).toList();
@@ skipping 21 matching lines @@
       }
     });
     if (matchingSuggestion == null) {
       fail("Expected '$completion' but found none:\n  $suggestedCompletions");
     }
     expect(matchingSuggestion.selectionOffset, equals(expectedOffset));
     expect(matchingSuggestion.selectionLength, equals(0));
   }
 
   void assertHasNoCompletion(String completion) {
-    // As a temporary measure, disable negative tests.
-    // TODO(paulberry): fix this.
-    return;
     if (suggestions.any(
         (CompletionSuggestion suggestion) => suggestion.completion == completion)) {
       fail(
           "Did not expect completion '$completion' but found:\n  $suggestedCompletions");
     }
   }
 
+  /**
+   * Discard any results that do not start with the characters the user has
+   * "already typed".
+   */
+  void filterResults(String content) {
+    String charsAlreadyTyped =
+        content.substring(replacementOffset, completionOffset).toLowerCase();
+    suggestions = suggestions.where(
+        (CompletionSuggestion suggestion) =>
+            suggestion.completion.toLowerCase().startsWith(charsAlreadyTyped)).toList();
+  }
+
   runTest(LocationSpec spec, [Map<String, String> extraFiles]) {
     super.setUp();
     return new Future(() {
       String content = spec.source;
       addFile(testFile, content);
       this.testCode = content;
       completionOffset = spec.testLocation;
       if (extraFiles != null) {
         extraFiles.forEach((String fileName, String content) {
           addFile(fileName, content);
         });
       }
     }).then((_) => getSuggestions()).then((_) {
-      //expect(replacementOffset, equals(completionOffset));
-      //expect(replacementLength, equals(0));
+      filterResults(spec.source);
       for (String result in spec.positiveResults) {
         assertHasCompletion(result);
       }
       for (String result in spec.negativeResults) {
         assertHasNoCompletion(result);
       }
     }).whenComplete(() {
       super.tearDown();
     });
   }
@@ skipping 164 matching lines @@
           err
               ..write(' ')
               ..write(ch);
         }
       }
       throw new IllegalStateException(err.toString());
     }
     return tests.values.toList();
   }
 }