Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 796063006: Rename Thread -> OSThread. (Closed)

Created:
5 years, 11 months ago by koda
Modified:
5 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Rename Thread -> OSThread. It's a collection of static utility methods for primitive operations on OS threads. Make room in the namespace for upcoming class that will represent all the complex state of a VM thread. Committed: https://code.google.com/p/dart/source/detail?r=42895

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -2158 lines) Patch
M runtime/vm/code_observers.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_state.h View 1 2 3 4 5 6 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/elfgen.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/freelist.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/freelist.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 5 6 5 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/lockers.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/message_handler.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/message_handler_test.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/native_symbol_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/os_linux.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + runtime/vm/os_thread.h View 1 2 3 4 5 6 3 chunks +10 lines, -8 lines 0 comments Download
A + runtime/vm/os_thread_android.h View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
A + runtime/vm/os_thread_android.cc View 1 2 3 9 chunks +20 lines, -19 lines 0 comments Download
A + runtime/vm/os_thread_linux.h View 1 2 3 4 5 3 chunks +6 lines, -6 lines 0 comments Download
A + runtime/vm/os_thread_linux.cc View 1 2 3 9 chunks +20 lines, -19 lines 0 comments Download
A + runtime/vm/os_thread_macos.h View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
A + runtime/vm/os_thread_macos.cc View 1 2 3 9 chunks +20 lines, -19 lines 0 comments Download
A + runtime/vm/os_thread_win.h View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
A + runtime/vm/os_thread_win.cc View 1 2 3 12 chunks +25 lines, -25 lines 0 comments Download
M runtime/vm/os_win.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/pages.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/port.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_arm.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/simulator_mips.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread.h View 1 2 3 4 5 6 1 chunk +0 lines, -110 lines 0 comments Download
D runtime/vm/thread_android.h View 1 2 3 4 5 6 1 chunk +0 lines, -75 lines 0 comments Download
M runtime/vm/thread_android.cc View 1 2 3 4 5 6 1 chunk +0 lines, -347 lines 0 comments Download
M runtime/vm/thread_interrupter.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread_interrupter.cc View 1 2 3 4 5 6 8 chunks +21 lines, -19 lines 0 comments Download
M runtime/vm/thread_interrupter_android.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread_interrupter_linux.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread_interrupter_macos.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread_interrupter_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread_linux.h View 1 2 3 4 5 6 1 chunk +0 lines, -75 lines 0 comments Download
M runtime/vm/thread_linux.cc View 1 2 3 4 5 6 1 chunk +0 lines, -351 lines 0 comments Download
D runtime/vm/thread_macos.h View 1 2 3 4 5 6 1 chunk +0 lines, -75 lines 0 comments Download
M runtime/vm/thread_macos.cc View 1 2 3 4 5 6 1 chunk +0 lines, -356 lines 0 comments Download
M runtime/vm/thread_pool.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/thread_pool.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
D runtime/vm/thread_win.h View 1 2 3 4 5 6 1 chunk +0 lines, -121 lines 0 comments Download
M runtime/vm/thread_win.cc View 1 2 3 4 5 6 1 chunk +0 lines, -461 lines 0 comments Download
M runtime/vm/vm_sources.gypi View 1 2 3 4 5 6 3 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
koda
5 years, 11 months ago (2015-01-14 18:39:58 UTC) #1
koda
I probably also want to rename the thread.h and thread_linux.{h,cc} etc. files. Maybe "synchronization", "os_threads", ...
5 years, 11 months ago (2015-01-14 19:33:54 UTC) #2
siva
I was wondering why not we rename it to OSThread instead of ThreadUtils. ThreadUtils sounds ...
5 years, 11 months ago (2015-01-15 01:17:30 UTC) #3
koda
On 2015/01/15 01:17:30, siva wrote: > I was wondering why not we rename it to ...
5 years, 11 months ago (2015-01-15 02:23:16 UTC) #4
koda
5 years, 11 months ago (2015-01-15 02:30:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as r42895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698