Issue 79513002: Fix resolution of packages in pub-build to allow '../../packages/foo/bar'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 79513002: Fix resolution of packages in pub-build to allow '../../packages/foo/bar' (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
7 years, 1 month ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix resolution of packages in pub-build to allow '../../packages/foo/bar' R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=30495

Patch Set 1 : #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -28 lines)			Patch
M	pkg/polymer/lib/src/build/common.dart	View	1 chunk	+37 lines, -24 lines	0 comments	Download
M	pkg/polymer/lib/src/build/import_inliner.dart	View	1 chunk	+1 line, -1 line	1 comment	Download
M	pkg/polymer/test/build/import_inliner_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/polymer/test/build/linter_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://codereview.chromium.org/79513002/diff/80001/pkg/polymer/lib/src/build/import_inliner.dart File pkg/polymer/lib/src/build/import_inliner.dart (right): https://codereview.chromium.org/79513002/diff/80001/pkg/polymer/lib/src/build/import_inliner.dart#newcode214 pkg/polymer/lib/src/build/import_inliner.dart:214: return href; this makes sure that we don't assign ...

7 years, 1 month ago (2013-11-20 22:44:18 UTC) #1

Siggi Cherem (dart-lang)

7 years, 1 month ago (2013-11-21 01:40:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30495 (presubmit successful).

Expand Messages | Collapse Messages