Fix resolution of packages in pub-build to allow '../../packages/foo/bar'

pkg/polymer/lib/src/build/common.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /** Common methods used by transfomers. */
 library polymer.src.build.common;
 
 import 'dart:async';
 
 import 'package:barback/barback.dart';
@@ skipping 107 matching lines @@
 // TODO(sigmund): delete once this is part of barback (dartbug.com/12610)
 AssetId resolve(AssetId source, String url, TransformLogger logger, Span span) {
   if (url == null || url == '') return null;
   var uri = Uri.parse(url);
   var urlBuilder = path.url;
   if (uri.host != '' || uri.scheme != '' || urlBuilder.isAbsolute(url)) {
     logger.error('absolute paths not allowed: "$url"', span: span);
     return null;
   }
 
-  var package;
-  var targetPath;
   var segments = urlBuilder.split(url);
-  if (segments[0] == 'packages') {
-    if (segments.length < 3) {
-      logger.error("incomplete packages/ path. It should have at least 3 "
-          "segments packages/name/path-from-name's-lib-dir", span: span);
-      return null;
-    }
-    package = segments[1];
-    targetPath = urlBuilder.join('lib',
-        urlBuilder.joinAll(segments.sublist(2)));
-  } else if (segments[0] == 'assets') {
-    if (segments.length < 3) {
-      logger.error("incomplete assets/ path. It should have at least 3 "
-          "segments assets/name/path-from-name's-asset-dir", span: span);
-    }
-    package = segments[1];
-    targetPath = urlBuilder.join('asset',
-        urlBuilder.joinAll(segments.sublist(2)));
-  } else {
-    package = source.package;
-    targetPath = urlBuilder.normalize(
-        urlBuilder.join(urlBuilder.dirname(source.path), url));
+  var prefix = segments[0];
+  var entryFolder = !source.path.startsWith('lib/') &&
+      !source.path.startsWith('asset/');
+
+  // URLs of the form "packages/foo/bar" seen under entry folders (like web/,
+  // test/, example/, etc) are resolved as an asset in another package.
+  if (entryFolder && (prefix == 'packages' || prefix == 'assets')) {
+    return _extractOtherPackageId(0, segments, logger, span);
   }
-  return new AssetId(package, targetPath);
+
+  var targetPath = urlBuilder.normalize(
+      urlBuilder.join(urlBuilder.dirname(source.path), url));
+
+  // Relative URLs of the form "../../packages/foo/bar" in an asset under lib/
+  // or asset/ are also resolved as an asset in another package.
+  segments = urlBuilder.split(targetPath);
+  if (!entryFolder && segments.length > 1 && segments[0] == '..' &&
+      (segments[1] == 'packages' || segments[1] == 'assets')) {
+    return _extractOtherPackageId(1, segments, logger, span);
+  }
+
+  // Otherwise, resolve as a path in the same package.
+  return new AssetId(source.package, targetPath);
+}
+
+AssetId _extractOtherPackageId(int index, List segments,
+    TransformLogger logger, Span span) {
+  if (index >= segments.length) return null;
+  var prefix = segments[index];
+  if (prefix != 'packages' && prefix != 'assets') return null;
+  var folder = prefix == 'packages' ? 'lib' : 'asset';
+  if (segments.length < index + 3) {
+    logger.error("incomplete $prefix/ path. It should have at least 3 "
+        "segments $prefix/name/path-from-name's-$folder-dir", span: span);
+    return null;
+  }
+  return new AssetId(segments[index + 1],
+      path.url.join(folder, path.url.joinAll(segments.sublist(index + 2))));
 }
 
 /**
  * Generate the import url for a file described by [id], referenced by a file
  * with [sourceId].
  */
 // TODO(sigmund): this should also be in barback (dartbug.com/12610)
 String assetUrlFor(AssetId id, AssetId sourceId, TransformLogger logger,
     {bool allowAssetUrl: false}) {
   // use package: and asset: urls if possible
@@ skipping 20 matching lines @@
   return builder.relative(builder.join('/', id.path),
       from: builder.join('/', builder.dirname(sourceId.path)));
 }
 
 
 /** Convert system paths to asset paths (asset paths are posix style). */
 String _systemToAssetPath(String assetPath) {
   if (path.Style.platform != path.Style.windows) return assetPath;
   return path.posix.joinAll(path.split(assetPath));
 }