Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Issue 792993004: Properly delete cached dependencies that should no longer be cached. (Closed)

Created:
6 years ago by nweiz
Modified:
6 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly delete cached dependencies that should no longer be cached. This fixes the "Could not find asset" issue people were seeing on "pub upgrade". R=rnystrom@google.com BUG=21810 Committed: https://code.google.com/p/dart/source/detail?r=42273

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -94 lines) Patch
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 2 chunks +16 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/get/cache_transformed_dependency_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/entrypoint.dart View 1 chunk +135 lines, -89 lines 0 comments Download
M sdk/lib/_internal/pub_generated/test/get/cache_transformed_dependency_test.dart View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years ago (2014-12-11 00:01:37 UTC) #1
Bob Nystrom
LGTM!
6 years ago (2014-12-11 00:04:10 UTC) #2
nweiz
6 years ago (2014-12-11 00:42:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42273 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698